[Docs] 로컬 프론트 테스트용 CORS/로그인 임시 오버라이드 원복 체크리스트 추가#32
Conversation
issue #31 대응으로 infra/terraform.tfvars의 app_frontend_url을 http://localhost:5173로 임시 변경했다. terraform.tfvars는 gitignore 대상이라 그 변경 자체는 git에 안 남으므로, 실제 배포 전 무엇을 원복해야 하는지 기록해둔다. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
📝 WalkthroughWalkthrough배포 전 Changes배포 원복 절차
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/before-prod-deploy-revert-issue-31.md`:
- Around line 45-46: Verify the application’s SSM parameter read timing and CD
rollout behavior before asserting that redeployment is required. If values are
read only at startup, document the required redeploy/restart and post-deployment
validation steps; if they are dynamically refreshed, revise the statement that
apply alone cannot update running containers.
- Around line 40-42: Update the fenced code block containing app_frontend_url to
declare the hcl language and ensure it has a blank line immediately before and
after the fence, resolving the MD031 and MD040 markdownlint warnings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e913157d-9169-4e32-b441-0fc41ed1a3c1
📒 Files selected for processing (1)
docs/before-prod-deploy-revert-issue-31.md
| ``` | ||
| app_frontend_url = "https://www.loovi.my" | ||
| ``` |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
코드 블록에 언어와 주변 빈 줄을 추가해 주세요.
Markdownlint의 MD031/MD040 경고를 해결하려면 fenced block을 hcl로 지정하고 앞뒤에 빈 줄을 둬야 합니다.
수정안
1. `infra/terraform.tfvars`에서 `app_frontend_url`을 원래 값으로 되돌린다.
+
- ```
+ ```hcl
app_frontend_url = "https://www.loovi.my"
```
+📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ``` | |
| app_frontend_url = "https://www.loovi.my" | |
| ``` |
🧰 Tools
🪛 markdownlint-cli2 (0.23.0)
[warning] 40-40: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
[warning] 40-40: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
[warning] 42-42: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/before-prod-deploy-revert-issue-31.md` around lines 40 - 42, Update the
fenced code block containing app_frontend_url to declare the hcl language and
ensure it has a blank line immediately before and after the fence, resolving the
MD031 and MD040 markdownlint warnings.
Source: Linters/SAST tools
| 3. 다음 배포(CD) 때 컨테이너가 SSM에서 값을 다시 읽어가므로, apply 후 재배포가 한 번 있어야 | ||
| 실제로 반영된다 — apply만 하고 재배포를 안 하면 이미 떠 있는 컨테이너는 이전 값을 계속 쓴다. |
There was a problem hiding this comment.
🩺 Stability & Availability | 🔵 Trivial
SSM 값을 읽는 시점과 재배포 보장을 확인해 주세요.
infra/modules/ssm_params/main.tf:68-76은 SSM 파라미터가 갱신되는 것만 보여 줍니다. 애플리케이션이 시작 시에만 값을 읽는지, CD가 반드시 새 컨테이너를 롤아웃하는지는 제공된 컨텍스트에서 확인되지 않습니다. 실제 동작이 startup-only라면 재배포/재시작과 배포 후 검증 절차를 명시하고, 동적 조회라면 “apply만으로는 반영되지 않는다”는 문구를 조정해 주세요.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/before-prod-deploy-revert-issue-31.md` around lines 45 - 46, Verify the
application’s SSM parameter read timing and CD rollout behavior before asserting
that redeployment is required. If values are read only at startup, document the
required redeploy/restart and post-deployment validation steps; if they are
dynamically refreshed, revise the statement that apply alone cannot update
running containers.
1 participant
📋 작업 내용
issue #31 대응으로 infra/terraform.tfvars의 app_frontend_url을 http://localhost:5173로 임시 변경했다. terraform.tfvars는 gitignore 대상이라 그 변경 자체는 git에 안 남으므로, 실제 배포 전 무엇을 원복해야
하는지 기록해둔다.
📝 변경 사항
📸 스크린샷 (선택사항)
📌 체크리스트
Summary by CodeRabbit